database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-28 11:55:03 +03:00
Code Activity

Fix new pg_upgrade query not to rely on regnamespace

Browse Source 
That was invented in 9.5, and pg_upgrade claims to support back to 9.0.
But we don't need that with a simple query change, tested by Tom Lane.

Discussion: https://postgr.es/m/202507041645.afjl5rssvrgu@alvherre.pgsql
This commit is contained in:
Álvaro Herrera
2025-07-04 21:30:05 +02:00
parent 5aba3e637d
commit 1e007722fa
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/bin/pg_upgrade/check.c
View File

@@ -1688,12 +1688,13 @@ check_for_not_null_inheritance(ClusterInfo *cluster)
log_opts.basedir, log_opts.basedir,
"not_null_inconsistent_columns.txt"); "not_null_inconsistent_columns.txt");
query = "SELECT cc.relnamespace::pg_catalog.regnamespace AS nspname, " query = "SELECT nspname, cc.relname, ac.attname "
" cc.relname, ac.attname "
"FROM pg_catalog.pg_inherits i, pg_catalog.pg_attribute ac, " "FROM pg_catalog.pg_inherits i, pg_catalog.pg_attribute ac, "
" pg_catalog.pg_attribute ap, pg_catalog.pg_class cc " " pg_catalog.pg_attribute ap, pg_catalog.pg_class cc, "
" pg_catalog.pg_namespace nc "
"WHERE cc.oid = ac.attrelid AND i.inhrelid = ac.attrelid " "WHERE cc.oid = ac.attrelid AND i.inhrelid = ac.attrelid "
" AND i.inhparent = ap.attrelid AND ac.attname = ap.attname " " AND i.inhparent = ap.attrelid AND ac.attname = ap.attname "
" AND cc.relnamespace = nc.oid "
" AND ap.attnum > 0 and ap.attnotnull AND NOT ac.attnotnull"; " AND ap.attnum > 0 and ap.attnotnull AND NOT ac.attnotnull";
task = upgrade_task_create(); task = upgrade_task_create();