database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Get rid of the separate serial_schedule list of tests.

Browse Source 
Having to maintain two lists of regression test scripts has proven
annoyingly error-prone.  We can achieve the effect of the
serial_schedule by running the parallel_schedule with
"--max_connections=1"; so do that and remove serial_schedule.

This causes cosmetic differences in the progress output, but it
doesn't seem worth restructuring pg_regress to avoid that.

Discussion: https://postgr.es/m/899209.1620759506@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2021-05-11 17:52:04 -04:00
parent 5b2d09beaf
commit 1df3555acc
3 changed files with 15 additions and 215 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/tools/msvc/vcregress.pl
View File

@ -106,6 +106,12 @@ exit 0;
sub installcheck_internal
{
my ($schedule, @EXTRA_REGRESS_OPTS) = @_;
# for backwards compatibility, "serial" runs the tests in
# parallel_schedule one by one.
my $maxconn = $maxconn;
$maxconn = "--max_connections=1" if $schedule eq 'serial';
$schedule = 'parallel' if $schedule eq 'serial';
my @args = (
"../../../$Config/pg_regress/pg_regress",
"--dlpath=.",
@ -132,6 +138,12 @@ sub installcheck
sub check
{
my $schedule = shift || 'parallel';
# for backwards compatibility, "serial" runs the tests in
# parallel_schedule one by one.
my $maxconn = $maxconn;
$maxconn = "--max_connections=1" if $schedule eq 'serial';
$schedule = 'parallel' if $schedule eq 'serial';
InstallTemp();
chdir "${topdir}/src/test/regress";
my @args = (