From 1d9c5d0ce2dcac05850401cf266a9df10a68de49 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Fri, 2 Apr 2021 20:01:14 -0700 Subject: [PATCH] Do not rely on pgstat.h to indirectly include storage/ headers. An upcoming patch might remove the (now indirect) proc.h include (which in turn includes other headers), and it's cleaner for the modified files to include their dependencies directly anyway... Discussion: https://postgr.es/m/20210402194458.2vu324hkk2djq6ce@alap3.anarazel.de --- contrib/pg_stat_statements/pg_stat_statements.c | 2 ++ src/backend/postmaster/pgarch.c | 2 ++ src/backend/postmaster/pgstat.c | 1 + src/backend/replication/walreceiver.c | 1 + src/backend/storage/lmgr/lmgr.c | 1 + src/backend/utils/adt/misc.c | 1 + 6 files changed, 8 insertions(+) diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index 6feea2ab4f4..1141d2b0673 100644 --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statements/pg_stat_statements.c @@ -76,6 +76,8 @@ #include "pgstat.h" #include "storage/fd.h" #include "storage/ipc.h" +#include "storage/lwlock.h" +#include "storage/shmem.h" #include "storage/spin.h" #include "tcop/utility.h" #include "utils/acl.h" diff --git a/src/backend/postmaster/pgarch.c b/src/backend/postmaster/pgarch.c index 746c836d420..dfc7abbc975 100644 --- a/src/backend/postmaster/pgarch.c +++ b/src/backend/postmaster/pgarch.c @@ -44,7 +44,9 @@ #include "storage/ipc.h" #include "storage/latch.h" #include "storage/pmsignal.h" +#include "storage/proc.h" #include "storage/procsignal.h" +#include "storage/shmem.h" #include "utils/guc.h" #include "utils/ps_status.h" diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c index de239136f48..498d6ee1236 100644 --- a/src/backend/postmaster/pgstat.c +++ b/src/backend/postmaster/pgstat.c @@ -61,6 +61,7 @@ #include "storage/latch.h" #include "storage/lmgr.h" #include "storage/pg_shmem.h" +#include "storage/proc.h" #include "storage/procsignal.h" #include "storage/sinvaladt.h" #include "utils/ascii.h" diff --git a/src/backend/replication/walreceiver.c b/src/backend/replication/walreceiver.c index 2b6fa4019b8..9a0e3806fcf 100644 --- a/src/backend/replication/walreceiver.c +++ b/src/backend/replication/walreceiver.c @@ -69,6 +69,7 @@ #include "replication/walsender.h" #include "storage/ipc.h" #include "storage/pmsignal.h" +#include "storage/proc.h" #include "storage/procarray.h" #include "storage/procsignal.h" #include "utils/acl.h" diff --git a/src/backend/storage/lmgr/lmgr.c b/src/backend/storage/lmgr/lmgr.c index 5736d03083f..cdf2266d6d5 100644 --- a/src/backend/storage/lmgr/lmgr.c +++ b/src/backend/storage/lmgr/lmgr.c @@ -23,6 +23,7 @@ #include "miscadmin.h" #include "pgstat.h" #include "storage/lmgr.h" +#include "storage/proc.h" #include "storage/procarray.h" #include "storage/sinvaladt.h" #include "utils/inval.h" diff --git a/src/backend/utils/adt/misc.c b/src/backend/utils/adt/misc.c index 634f574d7eb..88faf4dfd72 100644 --- a/src/backend/utils/adt/misc.c +++ b/src/backend/utils/adt/misc.c @@ -36,6 +36,7 @@ #include "postmaster/syslogger.h" #include "rewrite/rewriteHandler.h" #include "storage/fd.h" +#include "storage/latch.h" #include "tcop/tcopprot.h" #include "utils/builtins.h" #include "utils/fmgroids.h"