database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-16 06:01:02 +03:00
Code Activity

Finish up XLOG_HINT renaming

Browse Source 
Commit b8fd1a09f3 renamed XLOG_HINT to XLOG_FPI, but neglected two
places.

Backpatch to 9.3, like that commit.
This commit is contained in:
Alvaro Herrera
2016-06-17 18:05:55 -04:00
parent 71d05a2c7b
commit 1ca4a1b5d2
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/transam/README
View File

@ -627,7 +627,7 @@ of optimising for performance. When a hint is written we use
MarkBufferDirtyHint() to mark the block dirty. MarkBufferDirtyHint() to mark the block dirty.
If the buffer is clean and checksums are in use then If the buffer is clean and checksums are in use then
MarkBufferDirtyHint() inserts an XLOG_HINT record to ensure that we MarkBufferDirtyHint() inserts an XLOG_FPI record to ensure that we
take a full page image that includes the hint. We do this to avoid take a full page image that includes the hint. We do this to avoid
a partial page write, when we write the dirtied page. WAL is not a partial page write, when we write the dirtied page. WAL is not
written during recovery, so we simply skip dirtying blocks because written during recovery, so we simply skip dirtying blocks because

2
src/backend/storage/buffer/bufmgr.c
View File

@ -3352,7 +3352,7 @@ IncrBufferRefCount(Buffer buffer)
* This is essentially the same as MarkBufferDirty, except: * This is essentially the same as MarkBufferDirty, except:
* *
* 1. The caller does not write WAL; so if checksums are enabled, we may need * 1. The caller does not write WAL; so if checksums are enabled, we may need
* to write an XLOG_HINT WAL record to protect against torn pages. * to write an XLOG_FPI WAL record to protect against torn pages.
* 2. The caller might have only share-lock instead of exclusive-lock on the * 2. The caller might have only share-lock instead of exclusive-lock on the
* buffer's content lock. * buffer's content lock.
* 3. This function does not guarantee that the buffer is always marked dirty * 3. This function does not guarantee that the buffer is always marked dirty