database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-10 17:42:29 +03:00
Code Activity

Fix relcache to account properly for subtransaction status of 'new'

Browse Source 
relcache entries.  Also, change TransactionIdIsCurrentTransactionId()
so that if consulted during transaction abort, it will not say that
the aborted xact is still current.  (It would be better to ensure that
it's never called at all during abort, but I'm not sure we can easily
guarantee that.)  In combination, these fix a crash we have seen
occasionally during parallel regression tests of 8.0.
This commit is contained in:
Tom Lane
2004-08-28 20:31:44 +00:00
parent f900af7961
commit 1c72d0dec1
7 changed files with 132 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/access/hash/hashpage.c
View File

@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.43 2003/11/29 19:51:40 pgsql Exp $
* $PostgreSQL: pgsql/src/backend/access/hash/hashpage.c,v 1.44 2004/08/28 20:31:43 tgl Exp $
*
* NOTES
* Postgres hash pages look like ordinary relation pages. The opaque
@@ -44,14 +44,12 @@ static void _hash_splitbucket(Relation rel, Buffer metabuf,
/*
* We use high-concurrency locking on hash indexes (see README for an overview
* of the locking rules). There are two cases in which we don't do locking.
* One is when the index is newly created in the current transaction. Since
* the creating transaction has not committed, no one else can see the index,
* and there's no reason to take locks. The second case is for temp
* relations, which no one else can see either. (We still take buffer-level
* locks, but not lmgr locks.)
* of the locking rules). However, we can skip taking lmgr locks when the
* index is local to the current backend (ie, either temp or new in the
* current transaction). No one else can see it, so there's no reason to
* take locks. We still take buffer-level locks, but not lmgr locks.
*/
#define USELOCKING(rel) (!((rel)->rd_isnew || (rel)->rd_istemp))
#define USELOCKING(rel) (!RELATION_IS_LOCAL(rel))
/*