database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Remove useless Assert.

Browse Source 
Testing that an unsigned variable is >= 0 is pretty pointless,
as noted by Coverity and numerous buildfarm members.

In passing, add comment about new uses of "volatile" --- Coverity
doesn't much like that either, but it seems probably necessary.
This commit is contained in:
Tom Lane
2020-08-09 11:32:31 -04:00
parent 20e7e1fe31
commit 1c164ef3d2
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/replication/logical/reorderbuffer.c
View File

@ -1907,6 +1907,9 @@ ReorderBufferResetTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
* merge) and replay the changes in lsn order. * merge) and replay the changes in lsn order.
* *
* If streaming is true then data will be sent using stream API. * If streaming is true then data will be sent using stream API.
*
* Note: "volatile" markers on some parameters are to avoid trouble with
* PG_TRY inside the function.
*/ */
static void static void
ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn, ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
@ -2762,7 +2765,6 @@ ReorderBufferChangeMemoryUpdate(ReorderBuffer *rb,
} }
Assert(txn->size <= rb->size); Assert(txn->size <= rb->size);
Assert((txn->size >= 0) && (rb->size >= 0));
} }
/* /*