From 1bdd54e662d58ed49448255a004b668b56bae100 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 22 Aug 2022 20:25:42 -0700 Subject: [PATCH] Remove redundant call to pgstat_report_wal() pgstat_report_stat() will be called before shutdown so an explicit call to pgstat_report_wal() just before shutdown is redundant. This likely was not redundant before 5891c7a8ed8, but now it clearly is. Author: Melanie Plageman Reviewed-by: Andres Freund Discussion: https://www.postgresql.org/message-id/CAAKRu_aaq33UnG4TXq3S-OSXGWj1QGf0sU%2BECH4tNwGFNERkZA%40mail.gmail.com --- src/backend/postmaster/walwriter.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/backend/postmaster/walwriter.c b/src/backend/postmaster/walwriter.c index e926f8c27c7..beb46dcb55c 100644 --- a/src/backend/postmaster/walwriter.c +++ b/src/backend/postmaster/walwriter.c @@ -293,18 +293,7 @@ HandleWalWriterInterrupts(void) } if (ShutdownRequestPending) - { - /* - * Force reporting remaining WAL statistics at process exit. - * - * Since pgstat_report_wal is invoked with 'force' is false in main - * loop to avoid overloading the cumulative stats system, there may - * exist unreported stats counters for the WAL writer. - */ - pgstat_report_wal(true); - proc_exit(0); - } /* Perform logging of memory contexts of this process */ if (LogMemoryContextPending)