database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

ecpg: Fix NULL pointer dereference during connection lookup

Browse Source 
ECPGconnect() caches established connections to the server, supporting
the case of a NULL connection name when a database name is not specified
by its caller.

A follow-up call to ECPGget_PGconn() to get an established connection
from the cached set with a non-NULL name could cause a NULL pointer
dereference if a NULL connection was listed in the cache and checked for
a match.  At least two connections are necessary to reproduce the issue:
one with a NULL name and one with a non-NULL name.

Author:  Aleksander Alekseev <aleksander@tigerdata.com>
Discussion: https://postgr.es/m/CAJ7c6TNvFTPUTZQuNAoqgzaSGz-iM4XR61D7vEj5PsQXwg2RyA@mail.gmail.com
Backpatch-through: 13
This commit is contained in:
Michael Paquier
2025-07-22 14:00:00 +09:00
parent e2debb6438
commit 1b8bbee05d
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/interfaces/ecpg/ecpglib/connect.c
View File

@ -58,7 +58,12 @@ ecpg_get_connection_nr(const char *connection_name)
for (con = all_connections; con != NULL; con = con->next) for (con = all_connections; con != NULL; con = con->next)
{ {
if (strcmp(connection_name, con->name) == 0) /*
* Check for the case of a NULL connection name, stored as such in
* the connection information by ECPGconnect() when the database
* name is not specified by its caller.
*/
if (con->name != NULL && strcmp(connection_name, con->name) == 0)
break; break;
} }
ret = con; ret = con;