database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Convert hstore_in to report errors softly.

Browse Source 
The error reporting here was not only old and crufty, but untested.
I took the opportunity to bring the messages into some sort of
compliance with our message style guidelines.

Discussion: https://postgr.es/m/6B6A5C77-60AD-4A71-9F3A-B2C026A281A6@dunslane.net
This commit is contained in:
Tom Lane
2022-12-27 14:50:56 -05:00
parent a5434c5258
commit 197f98a848
3 changed files with 133 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
contrib/hstore/expected/hstore.out
View File

@ -243,6 +243,40 @@ select ' '::hstore;
(1 row)
-- invalid input
select ' =>null'::hstore;
ERROR: syntax error in hstore, near "=" at position 2
LINE 1: select ' =>null'::hstore;
^
select 'aa=>"'::hstore;
ERROR: syntax error in hstore: unexpected end of string
LINE 1: select 'aa=>"'::hstore;
^
-- also try it with non-error-throwing API
select pg_input_is_valid('a=>b', 'hstore');
pg_input_is_valid
-------------------
t
(1 row)
select pg_input_is_valid('a=b', 'hstore');
pg_input_is_valid
-------------------
f
(1 row)
select pg_input_error_message('a=b', 'hstore');
pg_input_error_message
------------------------------------------------
syntax error in hstore, near "b" at position 2
(1 row)
select pg_input_error_message(' =>b', 'hstore');
pg_input_error_message
------------------------------------------------
syntax error in hstore, near "=" at position 1
(1 row)
-- -> operator
select 'aa=>b, c=>d , b=>16'::hstore->'c';
?column?