Establish conventions about global object names used in regression tests.

mirror of https://github.com/postgres/postgres.git synced 2025-07-11 10:01:57 +03:00

To ensure that "make installcheck" can be used safely against an existing
installation, we need to be careful about what global object names
(database, role, and tablespace names) we use; otherwise we might
accidentally clobber important objects.  There's been a weak consensus that
test databases should have names including "regression", and that test role
names should start with "regress_", but we didn't have any particular rule
about tablespace names; and neither of the other rules was followed with
any consistency either.

This commit moves us a long way towards having a hard-and-fast rule that
regression test databases must have names including "regression", and that
test role and tablespace names must start with "regress_".  It's not
completely there because I did not touch some test cases in rolenames.sql
that test creation of special role names like "session_user".  That will
require some rethinking of exactly what we want to test, whereas the intent
of this patch is just to hit all the cases in which the needed renamings
are cosmetic.

There is no enforcement mechanism in this patch either, but if we don't
add one we can expect that the tests will soon be violating the convention
again.  Again, that's not such a cosmetic change and it will require
discussion.  (But I did use a quick-hack enforcement patch to find these
cases.)

Discussion: <16638.1468620817@sss.pgh.pa.us>

This commit is contained in:

Tom Lane

2016-07-17 18:42:31 -04:00

parent 7482fc4600

commit 18555b1323

173 changed files with 3334 additions and 3284 deletions

contrib

dblink

expected

dblink.out

sql

dblink.sql

file_fdw

input

file_fdw.source

output

file_fdw.source

sepgsql

expected

alter.out ddl.out

sql

alter.sql ddl.sql

test_decoding

expected

permissions.out

sql

permissions.sql

doc/src/sgml

dblink.sgml regress.sgml

src

bin

pg_dump

002_pg_dump.pl

scripts

040_createuser.pl 070_dropuser.pl

interfaces

ecpg

test

Makefile

compat_informix

test_informix2.pgc

connect

test1.pgc test2.pgc test3.pgc test5.pgc

expected

compat_informix-describe.c compat_informix-describe.stderr compat_informix-rnull.c compat_informix-rnull.stderr compat_informix-sqlda.c compat_informix-sqlda.stderr compat_informix-test_informix.c compat_informix-test_informix.stderr compat_informix-test_informix2.c compat_informix-test_informix2.stderr connect-test1-minGW32.stderr connect-test1.c connect-test1.stderr connect-test2.c connect-test2.stderr connect-test3.c connect-test3.stderr connect-test4.c connect-test4.stderr connect-test5.c connect-test5.stderr pgtypeslib-dt_test.c pgtypeslib-dt_test.stderr pgtypeslib-nan_test.c pgtypeslib-nan_test.stderr pgtypeslib-num_test.c pgtypeslib-num_test.stderr preproc-array_of_struct.c preproc-array_of_struct.stderr preproc-autoprep.c preproc-autoprep.stderr preproc-comment.c preproc-comment.stderr preproc-cursor.c preproc-cursor.stderr preproc-define.c preproc-define.stderr preproc-describe.c preproc-describe.stderr preproc-outofscope.c preproc-outofscope.stderr preproc-pointer_to_struct.c preproc-pointer_to_struct.stderr preproc-strings.c preproc-strings.stderr preproc-type.c preproc-type.stderr preproc-variable.c preproc-variable.stderr preproc-whenever.c preproc-whenever.stderr sql-array.c sql-array.stderr sql-binary.c sql-binary.stderr sql-code100.c sql-code100.stderr sql-copystdout.c sql-copystdout.stderr sql-define.c sql-define.stderr sql-desc.c sql-desc.stderr sql-describe.c sql-describe.stderr sql-dynalloc.c sql-dynalloc.stderr sql-dynalloc2.c sql-dynalloc2.stderr sql-dyntest.c sql-dyntest.stderr sql-execute.c sql-execute.stderr sql-fetch.c sql-fetch.stderr sql-func.c sql-func.stderr sql-indicators.c sql-indicators.stderr sql-insupd.c sql-insupd.stderr sql-oldexec.c sql-oldexec.stderr sql-parser.c sql-parser.stderr sql-quote.c sql-quote.stderr sql-show.c sql-show.stderr sql-sqlda.c sql-sqlda.stderr thread-alloc.c thread-prep.c thread-thread.c thread-thread_implicit.c

regression.h

test

isolation

isolation_main.c

modules

dummy_seclabel

expected

dummy_seclabel.out

sql

dummy_seclabel.sql

test_ddl_deparse

expected

alter_function.out

sql

alter_function.sql

test_pg_dump

001_base.pl

test_pg_dump--1.0.sql

test_rls_hooks

expected

test_rls_hooks.out

sql

test_rls_hooks.sql

regress

tools

msvc

vcregress.pl

									
										2

src/interfaces/ecpg/test/expected/sql-execute.c
									
				@ -58,7 +58,7 @@ main(void)

					ECPGdebug(1, stderr);

					{ ECPGconnect(__LINE__, 0, "regress1" , NULL, NULL , "main", 0); 

					{ ECPGconnect(__LINE__, 0, "ecpg1_regression" , NULL, NULL , "main", 0); 

				#line 24 "execute.pgc"

				if (sqlca.sqlcode < 0) sqlprint();}

Establish conventions about global object names used in regression tests.

2 src/interfaces/ecpg/test/expected/sql-execute.c

2

src/interfaces/ecpg/test/expected/sql-execute.c