From 180cf876d457c260291af070d883c5db5033cb3a Mon Sep 17 00:00:00 2001 From: Peter Geoghegan Date: Mon, 9 Nov 2020 09:00:12 -0800 Subject: [PATCH] Remove ineffective heapam CHECK_FOR_INTERRUPTS(). Remove a CHECK_FOR_INTERRUPTS() call that could never actually handle an interrupt. We always have a heap page buffer lock at this point. Having a useless CHECK_FOR_INTERRUPTS() call is harmless but misleading. It is probably possible to work around the immediate problem by moving the CHECK_FOR_INTERRUPTS() to before the heap page buffer lock is acquired. That isn't enough to make the function responsive to interrupts, though. The index AM caller will still hold an exclusive buffer lock of its own. --- src/backend/access/heap/heapam.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index 1585861a021..1b2f70499e5 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -7086,7 +7086,6 @@ heap_compute_xid_horizon_for_tuples(Relation rel, { hoffnum = ItemIdGetRedirect(hitemid); hitemid = PageGetItemId(hpage, hoffnum); - CHECK_FOR_INTERRUPTS(); } /*