database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Dial back -Wimplicit-fallthrough to level 3

Browse Source 
The additional pain from level 4 is excessive for the gain.

Also revert all the source annotation changes to their original
wordings, to avoid back-patching pain.

Discussion: https://postgr.es/m/31166.1589378554@sss.pgh.pa.us
This commit is contained in:
Alvaro Herrera
2020-05-13 15:31:14 -04:00
parent 81ca868630
commit 17cc133f01
34 changed files with 194 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/timezone/Makefile
View File

@ -55,11 +55,6 @@ ifeq (,$(ZIC))
ZIC= ./zic
endif
# zic.c doesn't compile cleanly with our default
# -Wimplicit-fallthrough=4, and we don't want to touch the file since
# it's third-party code, so downgrade to 3 for that file.
zic.o: CFLAGS := $(subst -Wimplicit-fallthrough=4,-Wimplicit-fallthrough=3,$(CFLAGS))
zic: $(ZICOBJS) | submake-libpgport
$(CC) $(CFLAGS) $(ZICOBJS) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X)