database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-24 00:23:06 +03:00
Code Activity

Dial back -Wimplicit-fallthrough to level 3

Browse Source 
The additional pain from level 4 is excessive for the gain.

Also revert all the source annotation changes to their original
wordings, to avoid back-patching pain.

Discussion: https://postgr.es/m/31166.1589378554@sss.pgh.pa.us
This commit is contained in:
Alvaro Herrera
2020-05-13 15:31:14 -04:00
parent 81ca868630
commit 17cc133f01
34 changed files with 194 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/mb/mbutils.c
View File

@@ -1263,7 +1263,7 @@ pg_utf8_increment(unsigned char *charptr, int length)
charptr[3]++;
break;
}
/* FALLTHROUGH */
/* FALL THRU */
case 3:
a = charptr[2];
if (a < 0xBF)
@@ -1271,7 +1271,7 @@ pg_utf8_increment(unsigned char *charptr, int length)
charptr[2]++;
break;
}
/* FALLTHROUGH */
/* FALL THRU */
case 2:
a = charptr[1];
switch (*charptr)
@@ -1291,7 +1291,7 @@ pg_utf8_increment(unsigned char *charptr, int length)
charptr[1]++;
break;
}
/* FALLTHROUGH */
/* FALL THRU */
case 1:
a = *charptr;
if (a == 0x7F || a == 0xDF || a == 0xEF || a == 0xF4)