database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-30 06:01:21 +03:00
Code Activity

Dial back -Wimplicit-fallthrough to level 3

Browse Source 
The additional pain from level 4 is excessive for the gain.

Also revert all the source annotation changes to their original
wordings, to avoid back-patching pain.

Discussion: https://postgr.es/m/31166.1589378554@sss.pgh.pa.us
This commit is contained in:
Alvaro Herrera
2020-05-13 15:31:14 -04:00
parent 81ca868630
commit 17cc133f01
34 changed files with 194 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/replication/logical/reorderbuffer.c
View File

@@ -1589,7 +1589,7 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,
change = specinsert;
change->action = REORDER_BUFFER_CHANGE_INSERT;
/* FALLTHROUGH */
/* intentionally fall through */
case REORDER_BUFFER_CHANGE_INSERT:
case REORDER_BUFFER_CHANGE_UPDATE:
case REORDER_BUFFER_CHANGE_DELETE:

2
src/backend/replication/walreceiver.c
View File

@@ -215,7 +215,7 @@ WalReceiverMain(void)
case WALRCV_STOPPING:
/* If we've already been requested to stop, don't start up. */
walrcv->walRcvState = WALRCV_STOPPED;
/* FALLTHROUGH */
/* fall through */
case WALRCV_STOPPED:
SpinLockRelease(&walrcv->mutex);

2
src/backend/replication/walreceiverfuncs.c
View File

@@ -183,7 +183,7 @@ ShutdownWalRcv(void)
case WALRCV_WAITING:
case WALRCV_RESTARTING:
walrcv->walRcvState = WALRCV_STOPPING;
/* FALLTHROUGH */
/* fall through */
case WALRCV_STOPPING:
walrcvpid = walrcv->pid;
break;