mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
Revise GUC names quoting in messages again
After further review, we want to move in the direction of always quoting GUC names in error messages, rather than the previous (PG16) wildly mixed practice or the intermittent (mid-PG17) idea of doing this depending on how possibly confusing the GUC name is. This commit applies appropriate quotes to (almost?) all mentions of GUC names in error messages. It partially supersedesa243569bf6
and8d9978a717
, which had moved things a bit in the opposite direction but which then were abandoned in a partial state. Author: Peter Smith <smithpb2250@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPv-kSN8SkxSdoHano_wPubqcg5789ejhCDZAcLFceBR-w%40mail.gmail.com
This commit is contained in:
@ -1660,7 +1660,7 @@ pg_stat_statements_internal(FunctionCallInfo fcinfo,
|
||||
if (!pgss || !pgss_hash)
|
||||
ereport(ERROR,
|
||||
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
|
||||
errmsg("pg_stat_statements must be loaded via shared_preload_libraries")));
|
||||
errmsg("pg_stat_statements must be loaded via \"shared_preload_libraries\"")));
|
||||
|
||||
InitMaterializedSRF(fcinfo, 0);
|
||||
|
||||
@ -1989,7 +1989,7 @@ pg_stat_statements_info(PG_FUNCTION_ARGS)
|
||||
if (!pgss || !pgss_hash)
|
||||
ereport(ERROR,
|
||||
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
|
||||
errmsg("pg_stat_statements must be loaded via shared_preload_libraries")));
|
||||
errmsg("pg_stat_statements must be loaded via \"shared_preload_libraries\"")));
|
||||
|
||||
/* Build a tuple descriptor for our result type */
|
||||
if (get_call_result_type(fcinfo, NULL, &tupdesc) != TYPEFUNC_COMPOSITE)
|
||||
@ -2671,7 +2671,7 @@ entry_reset(Oid userid, Oid dbid, uint64 queryid, bool minmax_only)
|
||||
if (!pgss || !pgss_hash)
|
||||
ereport(ERROR,
|
||||
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
|
||||
errmsg("pg_stat_statements must be loaded via shared_preload_libraries")));
|
||||
errmsg("pg_stat_statements must be loaded via \"shared_preload_libraries\"")));
|
||||
|
||||
LWLockAcquire(pgss->lock, LW_EXCLUSIVE);
|
||||
num_entries = hash_get_num_entries(pgss_hash);
|
||||
|
Reference in New Issue
Block a user