database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Revert "Allow --with-bonjour to work with non-macOS implementations of Bonjour."

Browse Source 
Upon further review, our Bonjour code doesn't actually work with the
Avahi not-too-compatible compatibility library.  While you can get it
to work on non-macOS platforms if you link to Apple's own mDNSResponder
code, there don't seem to be many people who care about that.  Leaving in
the AC_SEARCH_LIBS call seems more likely to encourage people to build
broken configurations than to do anything very useful.

Hence, remove the AC_SEARCH_LIBS call and put in a warning comment instead.

Discussion: https://postgr.es/m/2D8331C5-D64F-44C1-8717-63EDC6EAF7EB@brightforge.com
This commit is contained in:
Tom Lane
2017-11-09 11:00:36 -05:00
parent 58bc9ea033
commit 1772c5c6ee
2 changed files with 6 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
configure.in
View File

@ -1293,8 +1293,12 @@ fi
if test "$with_bonjour" = yes ; then
AC_CHECK_HEADER(dns_sd.h, [], [AC_MSG_ERROR([header file <dns_sd.h> is required for Bonjour])])
AC_SEARCH_LIBS(DNSServiceRefSockFD, dns_sd, [],
[AC_MSG_ERROR([could not find function 'DNSServiceRefSockFD' required for Bonjour])])
dnl At some point we might add something like
dnl AC_SEARCH_LIBS(DNSServiceRegister, dns_sd)
dnl but right now, what that would mainly accomplish is to encourage
dnl people to try to use the avahi implementation, which does not work.
dnl If you want to use Apple's own Bonjour code on another platform,
dnl just add -ldns_sd to LIBS manually.
fi
# for contrib/uuid-ossp