database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-05 02:22:28 +03:00
Code Activity

Remove pg_replication_origin's TOAST table.

Browse Source 
A few places that access this catalog don't set up an active
snapshot before potentially accessing its TOAST table.  However,
roname (the replication origin name) is the only varlena column, so
this is only a problem if the name requires out-of-line storage.
This commit removes its TOAST table to avoid needing to set up a
snapshot.  It also places a limit on replication origin names so
that attempts to set long names will fail with a more user-friendly
error.  Those chosen limit of 512 bytes should be sufficient to
avoid "row is too big" errors independent of BLCKSZ, but it should
also be lenient enough for all reasonable use-cases.

Bumps catversion.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Euler Taveira <euler@eulerto.com>
Reviewed-by: Nisha Moond <nisha.moond412@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/ZvMSUPOqUU-VNADN%40nathan
This commit is contained in:
Nathan Bossart
2025-05-07 14:47:36 -05:00
parent 5f4d98d4f3
commit 16bf24e0e4
10 changed files with 51 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/backend/replication/logical/origin.c
View File

@@ -264,6 +264,18 @@ replorigin_create(const char *roname)
SysScanDesc scan;
ScanKeyData key;
/*
* To avoid needing a TOAST table for pg_replication_origin, we limit
* replication origin names to 512 bytes. This should be more than enough
* for all practical use.
*/
if (strlen(roname) > MAX_RONAME_LEN)
ereport(ERROR,
(errcode(ERRCODE_PROGRAM_LIMIT_EXCEEDED),
errmsg("replication origin name is too long"),
errdetail("Replication origin names must be no longer than %d bytes.",
MAX_RONAME_LEN)));
roname_d = CStringGetTextDatum(roname);
Assert(IsTransactionState());
@@ -287,6 +299,17 @@ replorigin_create(const char *roname)
rel = table_open(ReplicationOriginRelationId, ExclusiveLock);
/*
* We want to be able to access pg_replication_origin without setting up a
* snapshot. To make that safe, it needs to not have a TOAST table, since
* TOASTed data cannot be fetched without a snapshot. As of this writing,
* its only varlena column is roname, which we limit to 512 bytes to avoid
* needing out-of-line storage. If you add a TOAST table to this catalog,
* be sure to set up a snapshot everywhere it might be needed. For more
* information, see https://postgr.es/m/ZvMSUPOqUU-VNADN%40nathan.
*/
Assert(!OidIsValid(rel->rd_rel->reltoastrelid));
for (roident = InvalidOid + 1; roident < PG_UINT16_MAX; roident++)
{
bool nulls[Natts_pg_replication_origin];