database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-02 04:21:28 +03:00
Code Activity

Get rid of the former rather baroque mechanism for propagating the values

Browse Source 
of ThisStartUpID and RedoRecPtr into new backends.  It's a lot easier just
to make them all grab the values out of shared memory during startup.
This helps to decouple the postmaster from checkpoint execution, which I
need since I'm intending to let the bgwriter do it instead, and it also
fixes a bug in the Win32 port: ThisStartUpID wasn't getting propagated at
all AFAICS.  (Doesn't give me a lot of faith in the amount of testing that
port has gotten.)
This commit is contained in:
Tom Lane
2004-05-27 17:12:57 +00:00
parent bb44a7c525
commit 16974ee910
6 changed files with 38 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/postmaster/postmaster.c
View File

@@ -37,7 +37,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.396 2004/05/27 15:07:41 momjian Exp $
* $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.397 2004/05/27 17:12:52 tgl Exp $
*
* NOTES
*
@@ -1909,8 +1909,8 @@ reaper(SIGNAL_ARGS)
* trouble...
*/
win32_RemoveChild(pid);
#endif
#endif
#endif /* WIN32 */
#endif /* HAVE_WAITPID */
/*
* Check if this child was the statistics collector. If so, try to
@@ -1953,14 +1953,9 @@ reaper(SIGNAL_ARGS)
StartupPID = 0;
/*
* Startup succeeded - remember its ID and RedoRecPtr.
*
* NB: this MUST happen before we fork a checkpoint or shutdown
* subprocess, else they will have wrong local ThisStartUpId.
* Startup succeeded - we are done with system startup or recovery.
*/
SetThisStartUpID();
FatalError = false; /* done with recovery */
FatalError = false;
/*
* Arrange for first checkpoint to occur after standard delay.
@@ -2073,8 +2068,6 @@ CleanupProc(int pid,
if (!FatalError)
{
checkpointed = time(NULL);
/* Update RedoRecPtr for future child backends */
GetSavedRedoRecPtr();
}
}
else if (pid == BgWriterPID)
@@ -3287,7 +3280,6 @@ postmaster_error(const char *fmt,...)
* functions
*/
#include "storage/spin.h"
extern XLogRecPtr RedoRecPtr;
extern XLogwrtResult LogwrtResult;
extern slock_t *ShmemLock;
extern slock_t *ShmemIndexLock;
@@ -3351,7 +3343,6 @@ write_backend_variables(Port *port)
}
write_var(MyCancelKey, fp);
write_var(RedoRecPtr, fp);
write_var(LogwrtResult, fp);
write_var(UsedShmemSegID, fp);
@@ -3416,7 +3407,6 @@ read_backend_variables(unsigned long id, Port *port)
}
read_var(MyCancelKey, fp);
read_var(RedoRecPtr, fp);
read_var(LogwrtResult, fp);
read_var(UsedShmemSegID, fp);