database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-27 22:56:53 +03:00
Code

Fix ancient connection leak in dblink

Browse Source 
When using unnamed connections with dblink, every time a new
connection is made, the old one is leaked. Fix that.

This has been an issue probably since dblink was first committed.
Someone complained almost ten years ago, but apparently I decided
not to pursue it at the time, and neither did anyone else, so it
slipped between the cracks. Now that someone else has complained,
fix in all supported branches.

Discussion: (orig) https://postgr.es/m/flat/F680AB59-6D6F-4026-9599-1BE28880273D%40decibel.org#F680AB59-6D6F-4026-9599-1BE28880273D@decibel.org
Discussion: (new) https://postgr.es/m/flat/0A3221C70F24FB45833433255569204D1F6ADF8C@G01JPEXMBYT05
Reported by: Jim Nasby and Takayuki Tsunakawa
This commit is contained in:
Joe Conway 2017-03-11 13:33:14 -08:00
parent 64d132c299
commit 166dfb3a90
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/dblink/dblink.c
View File

@ -301,7 +301,11 @@ dblink_connect(PG_FUNCTION_ARGS)
createNewConnection(connname, rconn); createNewConnection(connname, rconn);
} }
else else
{
if (pconn->conn)
PQfinish(pconn->conn);
pconn->conn = conn; pconn->conn = conn;
}
PG_RETURN_TEXT_P(cstring_to_text("OK")); PG_RETURN_TEXT_P(cstring_to_text("OK"));
} }