database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-08 07:21:33 +03:00
Code

Ensure interleaved_parts field is always initialized

Browse Source 
This field was recently added in db632fbca, however that commit missed one
place where it should have initialized the new field to NULL.  The missed
location is where the PartitionBoundInfo is created for partition-wise
join relations.  Technically there could be interleaved partitions in a
partition-wise join relation, but currently the only optimization we use
this field for only does so for base rels and other member rels.  So just
document that we don't populate this field for join rels.

Reported-by: Amit Langote
Author: Amit Langote, David Rowley
Reviewed-by: Amit Langote, David Rowley
Discussion: https://postgr.es/m/CA+HiwqE76Rps24kwHsd2Cr82Ua07tJC9t9reG0c7ScX9n_xrEA@mail.gmail.com
This commit is contained in:
David Rowley 2021-10-01 15:09:49 +13:00
parent 20f8671ef6
commit 16239c5fdf
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/partitioning/partbounds.c
View File

@ -2564,6 +2564,9 @@ build_merged_partition_bounds(char strategy, List *merged_datums,
merged_bounds->kind = NULL; merged_bounds->kind = NULL;
} }
/* interleaved_parts is always NULL for join relations. */
merged_bounds->interleaved_parts = NULL;
Assert(list_length(merged_indexes) == ndatums); Assert(list_length(merged_indexes) == ndatums);
merged_bounds->nindexes = ndatums; merged_bounds->nindexes = ndatums;
merged_bounds->indexes = (int *) palloc(sizeof(int) * ndatums); merged_bounds->indexes = (int *) palloc(sizeof(int) * ndatums);

4
src/include/partitioning/partbounds.h
View File

@ -72,7 +72,9 @@ struct RelOptInfo; /* avoid including pathnodes.h here */
* contain any value that does not belong in another partition. This field * contain any value that does not belong in another partition. This field
* only serves as proof that a particular partition is not interleaved, not * only serves as proof that a particular partition is not interleaved, not
* proof that it is interleaved. When we're uncertain, we marked the * proof that it is interleaved. When we're uncertain, we marked the
* partition as interleaved. * partition as interleaved. The interleaved_parts field is only ever set for
* RELOPT_BASEREL and RELOPT_OTHER_MEMBER_REL, it is always left NULL for join
* relations.
*/ */
typedef struct PartitionBoundInfoData typedef struct PartitionBoundInfoData
{ {