database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-20 00:42:27 +03:00
Code

pg_standby: Avoid writing one byte beyond the end of the buffer.

Browse Source 
Previously, read() might have returned a length equal to the buffer
length, and then the subsequent store to buf[len] would write a
zero-byte one byte past the end.  This doesn't seem likely to be
a security issue, but there's some chance it could result in
pg_standby misbehaving.

Spotted by Coverity; patch by Michael Paquier, reviewed by me.
This commit is contained in:
Robert Haas 2015-01-15 09:26:03 -05:00
parent 741b1b22a2
commit 151fb75b0d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pg_standby/pg_standby.c
View File

@ -435,7 +435,7 @@ CheckForExternalTrigger(void)
return; return;
} }
if ((len = read(fd, buf, sizeof(buf))) < 0) if ((len = read(fd, buf, sizeof(buf) - 1)) < 0)
{ {
fprintf(stderr, "WARNING: could not read \"%s\": %s\n", fprintf(stderr, "WARNING: could not read \"%s\": %s\n",
triggerPath, strerror(errno)); triggerPath, strerror(errno));