mirror of
https://github.com/postgres/postgres.git
synced 2025-10-18 04:29:09 +03:00
Assert that WaitLatch's timeout is not more than INT_MAX milliseconds.
The behavior with larger values is unspecified by the Single Unix Spec. It appears that BSD-derived kernels report EINVAL, although Linux does not. If waiting for longer intervals is desired, the calling code has to do something to limit the delay; we can't portably fix it here since "long" may not be any wider than "int" in the first place. Part of response to bug #7670, though this change doesn't fix that (in fact, it converts the problem from an ERROR into an Assert failure). No back-patch since it's just an assertion addition.
This commit is contained in:
@@ -20,6 +20,7 @@
|
||||
#include "postgres.h"
|
||||
|
||||
#include <fcntl.h>
|
||||
#include <limits.h>
|
||||
#include <signal.h>
|
||||
#include <unistd.h>
|
||||
|
||||
@@ -130,7 +131,7 @@ WaitLatchOrSocket(volatile Latch *latch, int wakeEvents, pgsocket sock,
|
||||
if (wakeEvents & WL_TIMEOUT)
|
||||
{
|
||||
INSTR_TIME_SET_CURRENT(start_time);
|
||||
Assert(timeout >= 0);
|
||||
Assert(timeout >= 0 && timeout <= INT_MAX);
|
||||
cur_timeout = timeout;
|
||||
}
|
||||
else
|
||||
|
Reference in New Issue
Block a user