database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-27 22:56:53 +03:00
Code

pg_upgrade: Add C comment about NextXID delimiter

Browse Source 
We don't test the catversion for the NextXID delimiter change, we just
test the string contents;  explain why.

Reported-by: Michael Paquier
This commit is contained in:
Bruce Momjian 2016-02-12 17:53:36 -05:00
parent 59a884e985
commit 13a6fa3634
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/bin/pg_upgrade/controldata.c
View File

@ -197,9 +197,14 @@ get_control_data(ClusterInfo *cluster, bool live_check)
p++; /* remove ':' char */ p++; /* remove ':' char */
cluster->controldata.chkpnt_nxtepoch = str2uint(p); cluster->controldata.chkpnt_nxtepoch = str2uint(p);
/*
* Delimiter changed from '/' to ':' in 9.6. We don't test for
* the catalog version of the change because the catalog version
* is pulled from pg_controldata too, and it isn't worth adding
* an order dependency for this --- we just check the string.
*/
if (strchr(p, '/') != NULL) if (strchr(p, '/') != NULL)
p = strchr(p, '/'); p = strchr(p, '/');
/* delimiter changed from '/' to ':' in 9.6 */
else if (GET_MAJOR_VERSION(cluster->major_version) >= 906) else if (GET_MAJOR_VERSION(cluster->major_version) >= 906)
p = strchr(p, ':'); p = strchr(p, ':');
else else