From 135b867a530cac2e3796d87c852b53bef40f0077 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Tue, 1 Sep 2026 11:14:25 +0200 Subject: [PATCH] Wait for checksum state transition in test The test for disabling data checksums after a failure didn't wait for the state transition to complete before testing, which could lead to false negatives in testing. Fix by passing the wait param when disabling. Identified on buildfarm member culicidae. Author: Daniel Gustafsson Reported-by: Alexander Lakhin Reviewed-by: Alexander Lakhin Discussion: https://postgr.es/m/b2f34fd3-8e98-450e-9e8c-ac08238e9116@gmail.com Backpatch-through: 19 --- src/test/modules/test_checksums/t/005_injection.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/modules/test_checksums/t/005_injection.pl b/src/test/modules/test_checksums/t/005_injection.pl index 92a4948f040..8dcbe971466 100644 --- a/src/test/modules/test_checksums/t/005_injection.pl +++ b/src/test/modules/test_checksums/t/005_injection.pl @@ -48,7 +48,7 @@ $node->safe_psql('postgres', "SELECT injection_points_detach('datachecksumsworker-fail-db-result');"); # Make sure that disabling after a failure works -disable_data_checksums($node); +disable_data_checksums($node, wait => 1); test_checksum_state($node, 'off'); # ---------------------------------------------------------------------------