database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-24 00:23:06 +03:00
Code Activity

Reduce excessive dereferencing of function pointers

Browse Source 
It is equivalent in ANSI C to write (*funcptr) () and funcptr().  These
two styles have been applied inconsistently.  After discussion, we'll
use the more verbose style for plain function pointer variables, to make
it clear that it's a variable, and the shorter style when the function
pointer is in a struct (s.func() or s->func()), because then it's clear
that it's not a plain function name, and otherwise the excessive
punctuation makes some of those invocations hard to read.

Discussion: https://www.postgresql.org/message-id/f52c16db-14ed-757d-4b48-7ef360b1631d@2ndquadrant.com
This commit is contained in:
Peter Eisentraut
2017-09-07 12:06:23 -04:00
parent 9d71323dac
commit 1356f78ea9
46 changed files with 249 additions and 250 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/utils/mmgr/portalmem.c
View File

@@ -420,7 +420,7 @@ MarkPortalDone(Portal portal)
*/
if (PointerIsValid(portal->cleanup))
{
(*portal->cleanup) (portal);
portal->cleanup(portal);
portal->cleanup = NULL;
}
}
@@ -448,7 +448,7 @@ MarkPortalFailed(Portal portal)
*/
if (PointerIsValid(portal->cleanup))
{
(*portal->cleanup) (portal);
portal->cleanup(portal);
portal->cleanup = NULL;
}
}
@@ -486,7 +486,7 @@ PortalDrop(Portal portal, bool isTopCommit)
*/
if (PointerIsValid(portal->cleanup))
{
(*portal->cleanup) (portal);
portal->cleanup(portal);
portal->cleanup = NULL;
}
@@ -786,7 +786,7 @@ AtAbort_Portals(void)
*/
if (PointerIsValid(portal->cleanup))
{
(*portal->cleanup) (portal);
portal->cleanup(portal);
portal->cleanup = NULL;
}
@@ -980,7 +980,7 @@ AtSubAbort_Portals(SubTransactionId mySubid,
*/
if (PointerIsValid(portal->cleanup))
{
(*portal->cleanup) (portal);
portal->cleanup(portal);
portal->cleanup = NULL;
}