database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

Save slot's restart_lsn when invalidated due to size

Browse Source 
We put it aside as invalidated_at, which let us show "lost" in
pg_replication slot.  Prior to this change, the state value was reported
as NULL.

Backpatch to 13.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m/20200617.101707.1735599255100002667.horikyota.ntt@gmail.com
Discussion: https://postgr.es/m/20200407.120905.1507671100168805403.horikyota.ntt@gmail.com
This commit is contained in:
Alvaro Herrera
2020-06-24 14:15:17 -04:00
parent 411493d701
commit 12e52ba5a7
5 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/replication/slot.c
View File

@ -1226,6 +1226,7 @@ restart:
(uint32) restart_lsn)));
SpinLockAcquire(&s->mutex);
s->data.invalidated_at = s->data.restart_lsn;
s->data.restart_lsn = InvalidXLogRecPtr;
SpinLockRelease(&s->mutex);
ReplicationSlotRelease();

11
src/backend/replication/slotfuncs.c
View File

@ -283,6 +283,7 @@ pg_get_replication_slots(PG_FUNCTION_ARGS)
bool nulls[PG_GET_REPLICATION_SLOTS_COLS];
WALAvailability walstate;
XLogSegNo last_removed_seg;
XLogRecPtr targetLSN;
int i;
if (!slot->in_use)
@ -342,7 +343,15 @@ pg_get_replication_slots(PG_FUNCTION_ARGS)
else
nulls[i++] = true;
walstate = GetWALAvailability(slot_contents.data.restart_lsn);
/*
* Report availability from invalidated_at when the slot has been
* invalidated; otherwise slots would appear as invalid without any
* more clues as to what happened.
*/
targetLSN = XLogRecPtrIsInvalid(slot_contents.data.restart_lsn) ?
slot_contents.data.invalidated_at :
slot_contents.data.restart_lsn;
walstate = GetWALAvailability(targetLSN);
switch (walstate)
{