database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-12 07:05:03 +03:00
Code Activity

Fix copy-pasto in freeing memory on error in vacuumlo.

Browse Source 
It's harmless to call PQfreemem() with a NULL argument, so the only
consequence was that if allocating 'schema' failed, but allocating 'table'
or 'field' succeeded, we would leak a bit of memory. That's highly
unlikely to happen, so this is just academical, but let's get it right.

Per bug  from Timur Birsh. Backpatch back to 9.5, where the
PQfreemem() calls were introduced.

Discussion: https://www.postgresql.org/message-id/15838-3221652c72c5e69d@postgresql.org
This commit is contained in:
Heikki Linnakangas
2019-06-07 12:43:55 +03:00
parent 17aa054a79
commit 12a45a20aa
1 changed files with 2 additions and 2 deletions

4
contrib/vacuumlo/vacuumlo.c

@@ -245,9 +245,9 @@ vacuumlo(const char *database, const struct _param *param)
PQfinish(conn);
if (schema != NULL)
PQfreemem(schema);
if (schema != NULL)
if (table != NULL)
PQfreemem(table);
if (schema != NULL)
if (field != NULL)
PQfreemem(field);
return -1;
}