1
0
mirror of https://github.com/postgres/postgres.git synced 2025-05-17 06:41:24 +03:00

Cap wal_buffers to avoid a server crash when it's set very large.

It must be possible to multiply wal_buffers by XLOG_BLCKSZ without
overflowing int, or calculations in StartupXLOG will go badly wrong
and crash the server.  Avoid that by imposing a maximum value on
wal_buffers.  This will be just under 2GB, assuming the usual value
for XLOG_BLCKSZ.

Josh Berkus, per an analysis by Andrew Gierth.
This commit is contained in:
Robert Haas 2015-08-04 12:58:54 -04:00
parent bd8f768926
commit 11ed4bab50

View File

@ -2050,7 +2050,7 @@ static struct config_int ConfigureNamesInt[] =
GUC_UNIT_XBLOCKS GUC_UNIT_XBLOCKS
}, },
&XLOGbuffers, &XLOGbuffers,
-1, -1, INT_MAX, -1, -1, (INT_MAX / XLOG_BLCKSZ),
check_wal_buffers, NULL, NULL check_wal_buffers, NULL, NULL
}, },