From 11ad3b35c25de6edcaa8a7695cb1d58650c546d3 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Thu, 22 May 2014 10:40:00 -0400 Subject: [PATCH] Remove unnecessary cleanup code. This is all inside a block guarded by op == DSM_OP_ATTACH, so it can never be the case that op == DSM_OP_CREATE. Reported by Coverity. --- src/backend/storage/ipc/dsm_impl.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c index 74dace999ef..0819641ad96 100644 --- a/src/backend/storage/ipc/dsm_impl.c +++ b/src/backend/storage/ipc/dsm_impl.c @@ -554,14 +554,6 @@ dsm_impl_sysv(dsm_op op, dsm_handle handle, Size request_size, if (shmctl(ident, IPC_STAT, &shm) != 0) { - int save_errno; - - /* Back out what's already been done. */ - save_errno = errno; - if (op == DSM_OP_CREATE) - shmctl(ident, IPC_RMID, NULL); - errno = save_errno; - ereport(elevel, (errcode_for_dynamic_shared_memory(), errmsg("could not stat shared memory segment \"%s\": %m",