mirror of
https://github.com/postgres/postgres.git
synced 2025-07-27 12:41:57 +03:00
Adjust WAL code so that checkpoints truncate the xlog at the previous
checkpoint's redo pointer, not its undo pointer, per discussion in pghackers a few days ago. No point in hanging onto undo information until we have the ability to do something with it --- and this solves a rather large problem with log space for long-running transactions. Also, change all calls of write() to detect the case where write returned a count less than requested, but failed to set errno. Presume that this situation indicates ENOSPC, and give the appropriate error message, rather than a random message associated with the previous value of errno.
This commit is contained in:
@ -155,9 +155,8 @@ int dbf_write_head(dbhead *dbh) {
|
||||
put_short(head.dbh_hlen, dbh->db_hlen);
|
||||
put_short(head.dbh_rlen, dbh->db_rlen);
|
||||
|
||||
if (write(dbh->db_fd, &head, sizeof(dbf_header)) == -1 ) {
|
||||
if (write(dbh->db_fd, &head, sizeof(dbf_header)) != sizeof(dbf_header))
|
||||
return DBF_ERROR;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
@ -180,14 +179,12 @@ int dbf_put_fields(dbhead *dbh) {
|
||||
field.dbf_flen = dbh->db_fields[t].db_flen;
|
||||
field.dbf_dec = dbh->db_fields[t].db_dec;
|
||||
|
||||
if (write(dbh->db_fd, &field, sizeof(dbf_field)) == -1) {
|
||||
if (write(dbh->db_fd, &field, sizeof(dbf_field)) != sizeof(dbf_field))
|
||||
return DBF_ERROR;
|
||||
}
|
||||
}
|
||||
|
||||
if (write(dbh->db_fd, &end, 1) == -1) {
|
||||
if (write(dbh->db_fd, &end, 1) != 1)
|
||||
return DBF_ERROR;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
@ -457,15 +454,13 @@ int dbf_put_record(dbhead *dbh, field *rec, u_long where) {
|
||||
idx += rec[t].db_flen;
|
||||
}
|
||||
|
||||
if (write(dbh->db_fd, data, dbh->db_rlen) == -1) {
|
||||
if (write(dbh->db_fd, data, dbh->db_rlen) != dbh->db_rlen)
|
||||
return DBF_ERROR;
|
||||
}
|
||||
|
||||
/* There's a 0x1A at the end of a dbf-file */
|
||||
if (where == dbh->db_records) {
|
||||
if (write(dbh->db_fd, &end, 1) == -1) {
|
||||
if (write(dbh->db_fd, &end, 1) != 1)
|
||||
return DBF_ERROR;
|
||||
}
|
||||
}
|
||||
|
||||
dbh->db_offset += dbh->db_rlen;
|
||||
|
Reference in New Issue
Block a user