database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Remove enum WaitEventExtension

Browse Source 
This enum was used to determine the first ID to use when assigning a
custom wait event for extensions, which is always 1.  It was kept so
as it would be possible to add new in-core wait events in the category
"Extension".  There is no such thing currently, so let's remove this
enum until a case justifying it pops up.  This makes the code simpler
and easier to understand.

This has as effect to switch back autoprewarm.c to use PG_WAIT_EXTENSION
rather than WAIT_EVENT_EXTENSION, on par with v16 and older stable
branches.

Thinko in c9af054653.

Reported-by: Peter Eisentraut
Discussion: https://postgr.es/m/195c6c45-abce-4331-be6a-e87724e1d060@eisentraut.org
This commit is contained in:
Michael Paquier
2024-05-17 12:29:57 +09:00
parent 372700cf30
commit 110eb4aefb
4 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/utils/activity/wait_event.c
View File

@ -89,8 +89,7 @@ typedef struct WaitEventExtensionCounterData
static WaitEventExtensionCounterData *WaitEventExtensionCounter;
/* first event ID of custom wait events for extensions */
#define NUM_BUILTIN_WAIT_EVENT_EXTENSION \
(WAIT_EVENT_EXTENSION_FIRST_USER_DEFINED - WAIT_EVENT_EXTENSION)
#define WAIT_EVENT_EXTENSION_INITIAL_ID 1
/* wait event info for extensions */
#define WAIT_EVENT_EXTENSION_INFO(eventId) (PG_WAIT_EXTENSION | eventId)
@ -129,7 +128,7 @@ WaitEventExtensionShmemInit(void)
if (!found)
{
/* initialize the allocation counter and its spinlock. */
WaitEventExtensionCounter->nextId = NUM_BUILTIN_WAIT_EVENT_EXTENSION;
WaitEventExtensionCounter->nextId = WAIT_EVENT_EXTENSION_INITIAL_ID;
SpinLockInit(&WaitEventExtensionCounter->mutex);
}
@ -244,7 +243,7 @@ GetWaitEventExtensionIdentifier(uint16 eventId)
WaitEventExtensionEntryById *entry;
/* Built-in event? */
if (eventId < NUM_BUILTIN_WAIT_EVENT_EXTENSION)
if (eventId < WAIT_EVENT_EXTENSION_INITIAL_ID)
return "Extension";
/* It is a user-defined wait event, so lookup hash table. */