From 10eae82b27cebbb9586cda8baf8e3226496891d0 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 10 Nov 2021 10:12:20 -0500 Subject: [PATCH] Fix thinko in assertion in basebackup.c. Commit 5a1007a5088cd6ddf892f7422ea8dbaef362372f tried to introduce an assertion that the block size was at least twice the size of a tar block, but I got the math wrong. My error was reported to me off-list. --- src/backend/replication/basebackup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c index 92430439f53..ec0485705df 100644 --- a/src/backend/replication/basebackup.c +++ b/src/backend/replication/basebackup.c @@ -376,7 +376,7 @@ perform_base_backup(basebackup_options *opt, bbsink *sink) else { /* Properly terminate the tarfile. */ - StaticAssertStmt(TAR_BLOCK_SIZE <= 2 * BLCKSZ, + StaticAssertStmt(2 * TAR_BLOCK_SIZE <= BLCKSZ, "BLCKSZ too small for 2 tar blocks"); memset(sink->bbs_buffer, 0, 2 * TAR_BLOCK_SIZE); bbsink_archive_contents(sink, 2 * TAR_BLOCK_SIZE); @@ -621,7 +621,7 @@ perform_base_backup(basebackup_options *opt, bbsink *sink) } /* Properly terminate the tar file. */ - StaticAssertStmt(TAR_BLOCK_SIZE <= 2 * BLCKSZ, + StaticAssertStmt(2 * TAR_BLOCK_SIZE <= BLCKSZ, "BLCKSZ too small for 2 tar blocks"); memset(sink->bbs_buffer, 0, 2 * TAR_BLOCK_SIZE); bbsink_archive_contents(sink, 2 * TAR_BLOCK_SIZE);