database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-24 10:47:04 +03:00
Code

Fix variable names mentioned in comment to match the code.

Browse Source 
Also, in another comment, explain why holding an insertion slot is a
critical section.

Per review by Amit Kapila.
This commit is contained in:
Heikki Linnakangas 2013-07-17 23:27:15 +03:00
parent 59c02a36f0
commit 107cbc90a7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/access/transam/xlog.c
View File

@ -1322,8 +1322,8 @@ ReserveXLogInsertLocation(int size, XLogRecPtr *StartPos, XLogRecPtr *EndPos,
* *
* A log-switch record is handled slightly differently. The rest of the * A log-switch record is handled slightly differently. The rest of the
* segment will be reserved for this insertion, as indicated by the returned * segment will be reserved for this insertion, as indicated by the returned
* *EndPos_p value. However, if we are already at the beginning of the current * *EndPos value. However, if we are already at the beginning of the current
* segment, *StartPos_p and *EndPos_p are set to the current location without * segment, *StartPos and *EndPos are set to the current location without
* reserving any space, and the function returns false. * reserving any space, and the function returns false.
*/ */
static bool static bool
@ -1575,7 +1575,9 @@ WALInsertSlotAcquireOne(int slotno)
/* /*
* Lock out cancel/die interrupts until we exit the code section protected * Lock out cancel/die interrupts until we exit the code section protected
* by the slot. This ensures that interrupts will not interfere with * by the slot. This ensures that interrupts will not interfere with
* manipulations of data structures in shared memory. * manipulations of data structures in shared memory. There is no cleanup
* mechanism to release the slot if the backend dies while holding one,
* so make this a critical section.
*/ */
START_CRIT_SECTION(); START_CRIT_SECTION();