database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-08 07:21:33 +03:00
Code

Silence another gcc 11 warning.

Browse Source 
Per buildfarm and local experimentation, bleeding-edge gcc isn't
convinced that the MemSet in reorder_function_arguments() is safe.
Shut it up by adding an explicit check that pronargs isn't negative,
and by changing MemSet to memset.  (It appears that either change is
enough to quiet the warning at -O2, but let's do both to be sure.)
This commit is contained in:
Tom Lane 2021-01-28 17:18:23 -05:00
parent 6f5c8a8ec2
commit 1046dbedde
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/optimizer/util/clauses.c
View File

@ -3805,9 +3805,9 @@ reorder_function_arguments(List *args, HeapTuple func_tuple)
int i; int i;
Assert(nargsprovided <= pronargs); Assert(nargsprovided <= pronargs);
if (pronargs > FUNC_MAX_ARGS) if (pronargs < 0 || pronargs > FUNC_MAX_ARGS)
elog(ERROR, "too many function arguments"); elog(ERROR, "too many function arguments");
MemSet(argarray, 0, pronargs * sizeof(Node *)); memset(argarray, 0, pronargs * sizeof(Node *));
/* Deconstruct the argument list into an array indexed by argnumber */ /* Deconstruct the argument list into an array indexed by argnumber */
i = 0; i = 0;