database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

GetPublicationByName: Don't repeat ourselves

Browse Source 
Use get_publication_oid() instead of reimplementing it.

Discussion: https://postgr.es/m/20191220201017.GA17292@alvherre.pgsql
This commit is contained in:
Alvaro Herrera
2019-12-23 12:47:36 -03:00
parent 696cc3a0ca
commit 0fd8cfb20d
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/catalog/pg_publication.c
View File

@ -374,7 +374,6 @@ GetPublication(Oid pubid)
Form_pg_publication pubform; Form_pg_publication pubform;
tup = SearchSysCache1(PUBLICATIONOID, ObjectIdGetDatum(pubid)); tup = SearchSysCache1(PUBLICATIONOID, ObjectIdGetDatum(pubid));
if (!HeapTupleIsValid(tup)) if (!HeapTupleIsValid(tup))
elog(ERROR, "cache lookup failed for publication %u", pubid); elog(ERROR, "cache lookup failed for publication %u", pubid);
@ -403,19 +402,9 @@ GetPublicationByName(const char *pubname, bool missing_ok)
{ {
Oid oid; Oid oid;
oid = GetSysCacheOid1(PUBLICATIONNAME, Anum_pg_publication_oid, oid = get_publication_oid(pubname, missing_ok);
CStringGetDatum(pubname));
if (!OidIsValid(oid))
{
if (missing_ok)
return NULL;
ereport(ERROR, return OidIsValid(oid) ? GetPublication(oid) : NULL;
(errcode(ERRCODE_UNDEFINED_OBJECT),
errmsg("publication \"%s\" does not exist", pubname)));
}
return GetPublication(oid);
} }
/* /*