From 0fc33b00536cf395b44260b6fc76b6b1d6fc0bcb Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 19 Nov 2025 08:46:31 +0100 Subject: [PATCH] Fix NLS for incorrect GUC enum value hint message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The translation markers were applied at the wrong place, so no string was extracted for translation. Also add translator comments here and in a similar place. Reviewed-by: Álvaro Herrera Discussion: https://www.postgresql.org/message-id/2c961fa1-14f6-44a2-985c-e30b95654e8d%40eisentraut.org --- src/backend/replication/logical/relation.c | 1 + src/backend/utils/misc/guc.c | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/backend/replication/logical/relation.c b/src/backend/replication/logical/relation.c index 745fd3bab64..10b3d0d9b82 100644 --- a/src/backend/replication/logical/relation.c +++ b/src/backend/replication/logical/relation.c @@ -249,6 +249,7 @@ logicalrep_get_attrs_str(LogicalRepRelation *remoterel, Bitmapset *atts) { attcnt++; if (attcnt > 1) + /* translator: This is a separator in a list of entity names. */ appendStringInfoString(&attsbuf, _(", ")); appendStringInfo(&attsbuf, _("\"%s\""), remoterel->attnames[i]); diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 7e2b17cc04e..526a57a16f8 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -3135,14 +3135,17 @@ parse_and_validate_value(const struct config_generic *record, char *hintmsg; hintmsg = config_enum_get_options(conf, - "Available values: ", - ".", ", "); + _("Available values: "), + /* translator: This is the terminator of a list of entity names. */ + _("."), + /* translator: This is a separator in a list of entity names. */ + _(", ")); ereport(elevel, (errcode(ERRCODE_INVALID_PARAMETER_VALUE), errmsg("invalid value for parameter \"%s\": \"%s\"", record->name, value), - hintmsg ? errhint("%s", _(hintmsg)) : 0)); + hintmsg ? errhint("%s", hintmsg) : 0)); if (hintmsg) pfree(hintmsg);