database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-12 21:01:52 +03:00
Code Activity

Fix relpersistence setting in reindex_index

Browse Source 
Buildfarm members with CLOBBER_CACHE_ALWAYS advised us that commit
85b506bbfc was mistaken in setting the relpersistence value of the
index directly in the relcache entry, within reindex_index.  The reason
for the failure is that an invalidation message that comes after mucking
with the relcache entry directly, but before writing it to the catalogs,
would cause the entry to become rebuilt in place from catalogs with the
old contents, losing the update.

Fix by passing the correct persistence value to
RelationSetNewRelfilenode instead; this routine also writes the updated
tuple to pg_class, avoiding the problem.  Suggested by Tom Lane.
This commit is contained in:
Alvaro Herrera
2014-11-17 11:23:35 -03:00
parent 7466a1b75f
commit 0f9692b40d
5 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/utils/cache/relcache.c vendored
View File

@ -3005,10 +3005,14 @@ RelationBuildLocalRelation(const char *relname,
* The relation is marked with relfrozenxid = freezeXid (InvalidTransactionId
* must be passed for indexes and sequences). This should be a lower bound on
* the XIDs that will be put into the new relation contents.
*
* The new filenode's persistence is set to the given value. This is useful
* for the cases that are changing the relation's persistence; other callers
* need to pass the original relpersistence value.
*/
void
RelationSetNewRelfilenode(Relation relation, TransactionId freezeXid,
MultiXactId minmulti)
RelationSetNewRelfilenode(Relation relation, char persistence,
TransactionId freezeXid, MultiXactId minmulti)
{
Oid newrelfilenode;
RelFileNodeBackend newrnode;
@ -3025,7 +3029,7 @@ RelationSetNewRelfilenode(Relation relation, TransactionId freezeXid,
/* Allocate a new relfilenode */
newrelfilenode = GetNewRelFileNode(relation->rd_rel->reltablespace, NULL,
relation->rd_rel->relpersistence);
persistence);
/*
* Get a writable copy of the pg_class tuple for the given relation.
@ -3048,7 +3052,7 @@ RelationSetNewRelfilenode(Relation relation, TransactionId freezeXid,
newrnode.node = relation->rd_node;
newrnode.node.relNode = newrelfilenode;
newrnode.backend = relation->rd_backend;
RelationCreateStorage(newrnode.node, relation->rd_rel->relpersistence);
RelationCreateStorage(newrnode.node, persistence);
smgrclosenode(newrnode);
/*
@ -3078,7 +3082,7 @@ RelationSetNewRelfilenode(Relation relation, TransactionId freezeXid,
}
classform->relfrozenxid = freezeXid;
classform->relminmxid = minmulti;
classform->relpersistence = relation->rd_rel->relpersistence;
classform->relpersistence = persistence;
simple_heap_update(pg_class, &tuple->t_self, tuple);
CatalogUpdateIndexes(pg_class, tuple);