database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-19 13:42:17 +03:00
Code Activity

Code review for 6190d828cd

Browse Source 
* Fix the comment of init_dummy_sjinfo() to remove references to
  non-existing parameters 'rel1' and 'rel2'.

* Adjust consider_new_or_clause() to call init_dummy_sjinfo() to make
  up a SpecialJoinInfo for inner joins like other code sites that
  were adjusted in 6190d828cd to do so.

Author: Richard Guo <guofenglinux@gmail.com>
Reported-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAExHW5tHqEf3ASVqvFFcghYGPfpy7o3xnvhHwBGbJFMRH8KjNw@mail.gmail.com
This commit is contained in:
Amit Langote
2024-03-25 19:43:29 +09:00
parent cc0e7ebd30
commit 0f7863afef
2 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/optimizer/path/joinrels.c
View File

@@ -656,8 +656,9 @@ join_is_legal(PlannerInfo *root, RelOptInfo *rel1, RelOptInfo *rel2,
/*
* init_dummy_sjinfo
* Populate the given SpecialJoinInfo for a plain inner join between rel1
* and rel2
* Populate the given SpecialJoinInfo for a plain inner join between the
* left and right relations specified by left_relids and right_relids
* respectively.
*
* Normally, an inner join does not have a SpecialJoinInfo node associated with
* it. But some functions involved in join planning require one containing at