From 0e032a2240a98669546023f7707030ea3ce4ded7 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 21 Mar 2025 15:14:15 -0400 Subject: [PATCH] Place "extern" declaration in the right part of pg_class.h. errdetail_relkind_not_supported() was declared within EXPOSE_TO_CLIENT_CODE, which is mistaken since that function isn't available client-side. While relatively harmless, this isn't good precedent. Discussion: https://postgr.es/m/1134562.1742507765@sss.pgh.pa.us --- src/include/catalog/pg_class.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/catalog/pg_class.h b/src/include/catalog/pg_class.h index fa96ba07bf4..07d182da796 100644 --- a/src/include/catalog/pg_class.h +++ b/src/include/catalog/pg_class.h @@ -231,8 +231,8 @@ MAKE_SYSCACHE(RELNAMENSP, pg_class_relname_nsp_index, 128); (relkind) == RELKIND_TOASTVALUE || \ (relkind) == RELKIND_MATVIEW) -extern int errdetail_relkind_not_supported(char relkind); - #endif /* EXPOSE_TO_CLIENT_CODE */ +extern int errdetail_relkind_not_supported(char relkind); + #endif /* PG_CLASS_H */