database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-29 22:49:41 +03:00
Code Activity

Fix replica identity check for INSERT ON CONFLICT DO UPDATE.

Browse Source 
If an INSERT has an ON CONFLICT DO UPDATE clause, the executor must
check that the target relation supports UPDATE as well as INSERT. In
particular, it must check that the target relation has a REPLICA
IDENTITY if it publishes updates. Formerly, it was not doing this
check, which could lead to silently breaking replication.

Fix by adding such a check to CheckValidResultRel(), which requires
adding a new onConflictAction argument. In back-branches, preserve ABI
compatibility by introducing a wrapper function with the original
signature.

Author: Zhijie Hou <houzj.fnst@fujitsu.com>
Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Tested-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/OS3PR01MB57180C87E43A679A730482DF94B62@OS3PR01MB5718.jpnprd01.prod.outlook.com
Backpatch-through: 13
This commit is contained in:
Dean Rasheed
2025-09-04 11:34:25 +01:00
parent 79ade58732
commit 0c4d5a45db
6 changed files with 81 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/backend/executor/execMain.c
View File

@@ -1010,11 +1010,15 @@ InitPlan(QueryDesc *queryDesc, int eflags)
* Generally the parser and/or planner should have noticed any such mistake
* already, but let's make sure.
*
* For INSERT ON CONFLICT, the result relation is required to support the
* onConflictAction, regardless of whether a conflict actually occurs.
*
* Note: when changing this function, you probably also need to look at
* CheckValidRowMarkRel.
*/
void
CheckValidResultRel(ResultRelInfo *resultRelInfo, CmdType operation)
CheckValidResultRelNew(ResultRelInfo *resultRelInfo, CmdType operation,
OnConflictAction onConflictAction)
{
Relation resultRel = resultRelInfo->ri_RelationDesc;
TriggerDesc *trigDesc = resultRel->trigdesc;
@@ -1029,6 +1033,13 @@ CheckValidResultRel(ResultRelInfo *resultRelInfo, CmdType operation)
case RELKIND_RELATION:
case RELKIND_PARTITIONED_TABLE:
CheckCmdReplicaIdentity(resultRel, operation);
/*
* For INSERT ON CONFLICT DO UPDATE, additionally check that the
* target relation supports UPDATE.
*/
if (onConflictAction == ONCONFLICT_UPDATE)
CheckCmdReplicaIdentity(resultRel, CMD_UPDATE);
break;
case RELKIND_SEQUENCE:
ereport(ERROR,
@@ -1147,6 +1158,16 @@ CheckValidResultRel(ResultRelInfo *resultRelInfo, CmdType operation)
}
}
/*
* ABI-compatible wrapper to emulate old version of the above function.
* Do not call this version in new code.
*/
void
CheckValidResultRel(ResultRelInfo *resultRelInfo, CmdType operation)
{
return CheckValidResultRelNew(resultRelInfo, operation, ONCONFLICT_NONE);
}
/*
* Check that a proposed rowmark target relation is a legal target
*