database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-06 19:59:18 +03:00
Code

pg_upgrade: Check all used executables

Browse Source 
Expand the validate_exec() calls to cover all the used binaries.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Discussion: https://www.postgresql.org/message-id/flat/9328.1552952117@sss.pgh.pa.us
This commit is contained in:
Peter Eisentraut 2019-07-27 07:48:08 +02:00
parent 28cb0555c1
commit 0befb4f313
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/bin/pg_upgrade/exec.c
View File

@ -376,6 +376,7 @@ check_bin_dir(ClusterInfo *cluster)
cluster->bindir); cluster->bindir);
validate_exec(cluster->bindir, "postgres"); validate_exec(cluster->bindir, "postgres");
validate_exec(cluster->bindir, "pg_controldata");
validate_exec(cluster->bindir, "pg_ctl"); validate_exec(cluster->bindir, "pg_ctl");
/* /*
@ -390,12 +391,20 @@ check_bin_dir(ClusterInfo *cluster)
validate_exec(cluster->bindir, "pg_resetxlog"); validate_exec(cluster->bindir, "pg_resetxlog");
else else
validate_exec(cluster->bindir, "pg_resetwal"); validate_exec(cluster->bindir, "pg_resetwal");
if (cluster == &new_cluster) if (cluster == &new_cluster)
{ {
/* these are only needed in the new cluster */ /*
validate_exec(cluster->bindir, "psql"); * These binaries are only needed for the target version. pg_dump and
* pg_dumpall are used to dump the old cluster, but must be of the
* target version.
*/
validate_exec(cluster->bindir, "initdb");
validate_exec(cluster->bindir, "pg_dump"); validate_exec(cluster->bindir, "pg_dump");
validate_exec(cluster->bindir, "pg_dumpall"); validate_exec(cluster->bindir, "pg_dumpall");
validate_exec(cluster->bindir, "pg_restore");
validate_exec(cluster->bindir, "psql");
validate_exec(cluster->bindir, "vacuumdb");
} }
} }