database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is

Browse Source 
not initialized if a log file is not specified on the command line.  This
causes an immediate segfault on systems that fill allocated memory with some
value other than zero (my FreeBSD machine uses 0xD0).

Several crashes later I discovered that args->user, password, host, and port
are also used without being initialized.

This doesn't appear to be fixed in CVS and I came up empty on a mailing list
search -- hope it hasn't been reported already.

Craig Boston
This commit is contained in:
Bruce Momjian
2003-12-01 23:14:29 +00:00
parent e1d2c43a22
commit 0bdc0a6d33
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/pg_autovacuum/pg_autovacuum.c
View File

@ -811,6 +811,11 @@ get_cmd_args(int argc, char *argv[])
args->analyze_scaling_factor = -1;
args->debug = AUTOVACUUM_DEBUG;
args->daemonize = 0;
args->user = 0;
args->password = 0;
args->host = 0;
args->logfile = 0;
args->port = 0;
/*
* Fixme: Should add some sanity checking such as positive integer