mirror of
https://github.com/postgres/postgres.git
synced 2025-09-02 04:21:28 +03:00
Allow concurrent-safe open() and fopen() in frontend code for Windows
PostgreSQL uses a custom wrapper for open() and fopen() which is concurrent-safe, allowing multiple processes to open and work on the same file. This has a couple of advantages: - pg_test_fsync does not handle O_DSYNC correctly otherwise, leading to false claims that disks are unsafe. - TAP tests can run into race conditions when a postmaster and pg_ctl open postmaster.pid, fixing some random failures in the buildfam. pg_upgrade is one frontend tool using workarounds to bypass file locking issues with the log files it generates, however the interactions with pg_ctl are proving to be tedious to get rid of, so this is left for later. Author: Laurenz Albe Reviewed-by: Michael Paquier, Kuntal Ghosh Discussion: https://postgr.es/m/1527846213.2475.31.camel@cybertec.at Discussion: https://postgr.es/m/16922.1520722108@sss.pgh.pa.us
This commit is contained in:
@@ -249,11 +249,8 @@ extern bool rmtree(const char *path, bool rmtopdir);
|
||||
#define O_DIRECT 0x80000000
|
||||
extern int pgwin32_open(const char *, int,...);
|
||||
extern FILE *pgwin32_fopen(const char *, const char *);
|
||||
|
||||
#ifndef FRONTEND
|
||||
#define open(a,b,c) pgwin32_open(a,b,c)
|
||||
#define fopen(a,b) pgwin32_fopen(a,b)
|
||||
#endif
|
||||
|
||||
/*
|
||||
* Mingw-w64 headers #define popen and pclose to _popen and _pclose. We want
|
||||
|
Reference in New Issue
Block a user