database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-20 00:42:27 +03:00
Code

pgstatindex: Insert some casts to prevent overflow.

Browse Source 
This could cause hash indexes to report greater than 100% free space.

Ashutosh Sharma, reviewed by Amit Kapila

Discussion: http://postgr.es/m/CAE9k0PnCKfg-ZK1CwGZJPF1yKcG2A=GUgC3BMdNMzLAXVOo4Eg@mail.gmail.com
This commit is contained in:
Robert Haas 2017-08-10 11:48:42 -04:00
parent ec99dd5aee
commit 0b7ba3d647
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/pgstattuple/pgstatindex.c
View File

@ -687,13 +687,14 @@ pgstathashindex(PG_FUNCTION_ARGS)
index_close(rel, AccessShareLock); index_close(rel, AccessShareLock);
/* Count unused pages as free space. */ /* Count unused pages as free space. */
stats.free_space += stats.unused_pages * stats.space_per_page; stats.free_space += (uint64) stats.unused_pages * stats.space_per_page;
/* /*
* Total space available for tuples excludes the metapage and the bitmap * Total space available for tuples excludes the metapage and the bitmap
* pages. * pages.
*/ */
total_space = (nblocks - (stats.bitmap_pages + 1)) * stats.space_per_page; total_space = (uint64) (nblocks - (stats.bitmap_pages + 1)) *
stats.space_per_page;
if (total_space == 0) if (total_space == 0)
free_percent = 0.0; free_percent = 0.0;