mirror of
https://github.com/postgres/postgres.git
synced 2025-07-02 09:02:37 +03:00
Use FLEXIBLE_ARRAY_MEMBER in a bunch more places.
Replace some bogus "x[1]" declarations with "x[FLEXIBLE_ARRAY_MEMBER]". Aside from being more self-documenting, this should help prevent bogus warnings from static code analyzers and perhaps compiler misoptimizations. This patch is just a down payment on eliminating the whole problem, but it gets rid of a lot of easy-to-fix cases. Note that the main problem with doing this is that one must no longer rely on computing sizeof(the containing struct), since the result would be compiler-dependent. Instead use offsetof(struct, lastfield). Autoconf also warns against spelling that offsetof(struct, lastfield[0]). Michael Paquier, review and additional fixes by me.
This commit is contained in:
2
src/backend/utils/cache/catcache.c
vendored
2
src/backend/utils/cache/catcache.c
vendored
@ -1590,7 +1590,7 @@ SearchCatCacheList(CatCache *cache,
|
||||
oldcxt = MemoryContextSwitchTo(CacheMemoryContext);
|
||||
nmembers = list_length(ctlist);
|
||||
cl = (CatCList *)
|
||||
palloc(sizeof(CatCList) + nmembers * sizeof(CatCTup *));
|
||||
palloc(offsetof(CatCList, members) +nmembers * sizeof(CatCTup *));
|
||||
heap_copytuple_with_tuple(ntp, &cl->tuple);
|
||||
MemoryContextSwitchTo(oldcxt);
|
||||
heap_freetuple(ntp);
|
||||
|
Reference in New Issue
Block a user