database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-13 07:41:39 +03:00
Code Activity

Remove redundant setting of hashkey after insertion

Browse Source 
It's not necessary to fill the key field in most cases, since
hash_search has already done that. Some existing call sites have an
assert or comment that this contract has been fulfilled, but those
are quite old and that practice seems unnecessary here.

While at it, remove a nearby redundant assignment that a smart compiler
will elide anyway.

Zhao Junwang, with some adjustments by me

Reviewed by Nathan Bossart, with additional feedback from Tom Lane

Discussion: http://postgr.es/m/CAEG8a3%2BUPF%3DR2QGPgJMF2mKh8xPd1H2TmfH77zPuVUFdBpiGUA%40mail.gmail.com
This commit is contained in:
John Naylor
2023-11-30 15:25:57 +07:00
parent 489ca33081
commit 095d109ccd
5 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/replication/logical/applyparallelworker.c
View File

@ -509,7 +509,6 @@ pa_allocate_worker(TransactionId xid)
winfo->in_use = true;
winfo->serialize_changes = false;
entry->winfo = winfo;
entry->xid = xid;
}
/*