database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

Fix resource owner code to generate catcache and relcache leak warnings

Browse Source 
when open references remain during normal cleanup of a resource owner.
This restores the system's ability to warn about leaks to what it was
before 8.0.  Not really a user-level bug, but helpful for development.
This commit is contained in:
Tom Lane
2005-03-25 18:30:28 +00:00
parent 6b7ef076b5
commit 08890b407e
3 changed files with 60 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/backend/utils/cache/catcache.c vendored
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/cache/catcache.c,v 1.118 2004/12/31 22:01:25 pgsql Exp $
* $PostgreSQL: pgsql/src/backend/utils/cache/catcache.c,v 1.119 2005/03/25 18:30:27 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -556,8 +556,7 @@ AtEOXact_CatCache(bool isCommit)
if (cl->refcount != 0)
{
if (isCommit)
elog(WARNING, "cache reference leak: cache %s (%d), list %p has count %d",
ccp->cc_relname, ccp->id, cl, cl->refcount);
PrintCatCacheListLeakWarning(cl);
cl->refcount = 0;
}
@ -579,10 +578,7 @@ AtEOXact_CatCache(bool isCommit)
if (ct->refcount != 0)
{
if (isCommit)
elog(WARNING, "cache reference leak: cache %s (%d), tuple %u has count %d",
ct->my_cache->cc_relname, ct->my_cache->id,
HeapTupleGetOid(&ct->tuple),
ct->refcount);
PrintCatCacheLeakWarning(&ct->tuple);
ct->refcount = 0;
}
@ -1807,3 +1803,32 @@ PrepareToInvalidateCacheTuple(Relation relation,
ccp->cc_relisshared ? (Oid) 0 : MyDatabaseId);
}
}
/*
* Subroutines for warning about reference leaks. These are exported so
* that resowner.c can call them.
*/
void
PrintCatCacheLeakWarning(HeapTuple tuple)
{
CatCTup *ct = (CatCTup *) (((char *) tuple) -
offsetof(CatCTup, tuple));
/* Safety check to ensure we were handed a cache entry */
Assert(ct->ct_magic == CT_MAGIC);
elog(WARNING, "cache reference leak: cache %s (%d), tuple %u/%u has count %d",
ct->my_cache->cc_relname, ct->my_cache->id,
ItemPointerGetBlockNumber(&(tuple->t_self)),
ItemPointerGetOffsetNumber(&(tuple->t_self)),
ct->refcount);
}
void
PrintCatCacheListLeakWarning(CatCList *list)
{
elog(WARNING, "cache reference leak: cache %s (%d), list %p has count %d",
list->my_cache->cc_relname, list->my_cache->id,
list, list->refcount);
}