database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Improve error reporting in format()

Browse Source 
Clarify invalid format conversion type error message and add hint.

Author: Jim Nasby
This commit is contained in:
Teodor Sigaev
2016-02-11 18:11:11 +03:00
parent a455878d99
commit 07d25a964b
2 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/regress/expected/text.out
View File

@ -211,7 +211,8 @@ ERROR: too few arguments for format
select format('Hello %s');
ERROR: too few arguments for format
select format('Hello %x', 20);
ERROR: unrecognized conversion type specifier "x"
ERROR: unrecognized format() type specifier "x"
HINT: For a single "%" use "%%".
-- check literal and sql identifiers
select format('INSERT INTO %I VALUES(%L,%L)', 'mytab', 10, 'Hello');
format
@ -263,9 +264,11 @@ ERROR: format specifies argument 0, but arguments are numbered from 1
select format('%*0$s', 'Hello');
ERROR: format specifies argument 0, but arguments are numbered from 1
select format('%1$', 1);
ERROR: unterminated format specifier
ERROR: unterminated format() type specifier
HINT: For a single "%" use "%%".
select format('%1$1', 1);
ERROR: unterminated format specifier
ERROR: unterminated format() type specifier
HINT: For a single "%" use "%%".
-- check mix of positional and ordered placeholders
select format('Hello %s %1$s %s', 'World', 'Hello again');
format