database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-29 13:56:47 +03:00
Code

Fix error reporting after ioctl() call with pg_upgrade --clone

Browse Source 
errno was not reported correctly after attempting to clone a file,
leading to incorrect error reports.  While scanning through the code, I
have not noticed any similar mistakes.

Error introduced in 3a769d8.

Author: Justin Pryzby
Discussion: https://postgr.es/m/20220731134135.GY15006@telsasoft.com
Backpatch-through: 12
This commit is contained in:
Michael Paquier 2022-08-01 16:39:16 +09:00
parent feae5c0cba
commit 07abcd9ab7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/pg_upgrade/file.c
View File

@ -57,9 +57,11 @@ cloneFile(const char *src, const char *dst,
if (ioctl(dest_fd, FICLONE, src_fd) < 0) if (ioctl(dest_fd, FICLONE, src_fd) < 0)
{ {
int save_errno = errno;
unlink(dst); unlink(dst);
pg_fatal("error while cloning relation \"%s.%s\" (\"%s\" to \"%s\"): %s\n", pg_fatal("error while cloning relation \"%s.%s\" (\"%s\" to \"%s\"): %s\n",
schemaName, relName, src, dst, strerror(errno)); schemaName, relName, src, dst, strerror(save_errno));
} }
close(src_fd); close(src_fd);