database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-31 22:04:40 +03:00
Code Activity

Correct obsolete nbtree page deletion comment.

Browse Source 
Commit efada2b8e9, which made the nbtree page deletion algorithm more
robust, removed _bt_getstackbuf() calls from _bt_pagedel().  It failed
to update a comment that referenced the earlier approach.  Update the
comment to explain that the _bt_getstackbuf() page deletion call site
mirrors the only other remaining _bt_getstackbuf() call site, which is
reached during page splits.
This commit is contained in:
Peter Geoghegan
2019-02-25 16:54:18 -08:00
parent b6926dee0e
commit 067786cea0
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/access/nbtree/nbtpage.c
View File

@ -1124,9 +1124,10 @@ _bt_is_page_halfdead(Relation rel, BlockNumber blk)
* *
* "child" is the leaf page we wish to delete, and "stack" is a search stack * "child" is the leaf page we wish to delete, and "stack" is a search stack
* leading to it (approximately). Note that we will update the stack * leading to it (approximately). Note that we will update the stack
* entry(s) to reflect current downlink positions --- this is harmless and * entry(s) to reflect current downlink positions --- this is essentially the
* indeed saves later search effort in _bt_pagedel. The caller should * same as the corresponding step of splitting, and is not expected to affect
* initialize *target and *rightsib to the leaf page and its right sibling. * caller. The caller should initialize *target and *rightsib to the leaf
* page and its right sibling.
* *
* Note: it's OK to release page locks on any internal pages between the leaf * Note: it's OK to release page locks on any internal pages between the leaf
* and *topparent, because a safe deletion can't become unsafe due to * and *topparent, because a safe deletion can't become unsafe due to